Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operations): make every CollationOptions property optional except locale #2727

Merged
merged 1 commit into from
Feb 2, 2021
Merged

fix(operations): make every CollationOptions property optional except locale #2727

merged 1 commit into from
Feb 2, 2021

Conversation

vkarpov15
Copy link
Contributor

Description

What changed?

Came up when working on Automattic/mongoose#9855: according to the server collation docs, every collation property except locale is optional.

Are there any files to ignore?

Nope

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nbbeeken nbbeeken merged commit 8a678e9 into mongodb:4.0 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants